-
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Craft CMS #990
Add Craft CMS #990
Conversation
@sindresorhus It's been almost 30 days since this PR was submitted. Over 2 months since this list was created. A good few hours of work put into this list. You've actively given your feedback on far newer PRs. Please review so I can get to fixing whatever issues need to be addressed and it can be merged. Thank you. |
|
@legodude17 I really appreciate the review! Good eye. I've addressed 3 of the 4 points you listed:
As for the article descriptions, the titles are descriptions themselves. I believe if I were to try & write additional descriptions, they would be redundant. I hope this practice is okay, as the lists that @sindresorhus maintains himself (and others I've seen) also follow the same format |
@chasegiunta Yeah, the articles do describe themselves. |
readme.md
Outdated
@@ -408,6 +408,7 @@ | |||
- [Wagtail](https://github.com/springload/awesome-wagtail) - Django CMS focused on flexibility and user experience. | |||
- [Textpattern](https://github.com/drmonkeyninja/awesome-textpattern) - Lightweight PHP-based CMS. | |||
- [Drupal](https://github.com/nirgn975/awesome-drupal) - Extensible PHP-based CMS. | |||
- [Craft CMS](https://github.com/chasegiunta/awesome-craft) - Content-first CMS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing a .
at the end.
@chasegiunta Please understand that I have a life outside of this project and open source. It's summer and I've been busy in real life. I have a lot of tabs open with things I need to do, and I don't always do them in order. You have spent a few hours creating your list, but I have spent hundreds of hours on this project. |
Back to the review:
|
@sindresorhus You're right. My frustration was mainly due to some newer PRs getting attention while this one remained unseen, but nevertheless in the scope of things, my impatience is uncalled for. I appreciate you making time for it! Made the following changes:
So, I only didn't apply the above format (dash to separate, uppercased first character, ending in dot) to the articles.
I did have "Third Party" resources listed at the very bottom, but "Community" better fits that section and encompasses official resources. Added: official Slack group, Twitter, and Facebook Links. There is an unofficial Craft subreddit, but it's not very active, and isn't an awesome resource imo. |
👍 |
https://github.com/chasegiunta/awesome-craft
Curated list of awesome Craft CMS plugins, technical articles/tutorials, and praise articles (sought by many developers promote & compare the platform). Craft is a CMS that’s laser-focused on doing one thing really, really well: managing content. Built to be as flexible as possible, without compromising on the ease of use for content authors.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
For example,
Add Name of List
, notUpdate readme.md
orAdd awesome list
.Example:
- [Fish](…) - User-friendly shell.
, not- [Fish](…) - Resources for Fish.
.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
A
/An
prefixes in the descriptions.Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.