Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Craft CMS #990

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Add Craft CMS #990

merged 1 commit into from
Jul 24, 2017

Conversation

chasegiunta
Copy link
Contributor

https://github.com/chasegiunta/awesome-craft

Curated list of awesome Craft CMS plugins, technical articles/tutorials, and praise articles (sought by many developers promote & compare the platform). Craft is a CMS that’s laser-focused on doing one thing really, really well: managing content. Built to be as flexible as possible, without compromising on the ease of use for content authors.

By submitting this pull request I confirm I've read and complied with the below requirements.

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

  • I have read and understood the contribution guidelines and the instructions for creating a list.
  • This pull request has a descriptive title.
    For example, Add Name of List, not Update readme.md or Add awesome list.
  • The entry in the Awesome list should:
    • Include a short description about the project/theme of the list. It should not describe the list itself.
      Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
    • Be added at the bottom of the appropriate category.
  • The list I'm submitting complies with these requirements:
    • Has been around for at least 30 days.
      That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
    • It's the result of hard work and the best I could possibly produce.
    • Non-generated Markdown file in a GitHub repo.
    • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
    • Not a duplicate.
    • Only has awesome items. Awesome lists are curations of the best, not everything.
    • Includes a project logo/illustration whenever possible.
      • Placed at the top-right of the readme. (Example)
      • The image should link to the project website or any relevant website.
      • The image should be high-DPI. Set it to maximum half the width of the original image.
    • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
    • Has the Awesome badge on the right side of the list heading,
    • Has a Table of Contents section.
      • Should be named Contents, not Table of Contents.
      • Should be the first section in the list.
    • Has an appropriate license.
      • That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
      • If you use a license badge, it should be SVG, not PNG.
    • Has contribution guidelines.
      • The file should be named contributing.md. Casing is up to you.
    • Has consistent formatting and proper spelling/grammar.
      • Each link description starts with an uppercase character and ends with a period.
        Example: - [AVA](…) - JavaScript test runner.
      • Drop all the A / An prefixes in the descriptions.
      • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
    • Doesn't include a Travis badge.
      You can still use Travis for list linting, but the badge has no value in the readme.
  • Go to the top and read it again.

@chasegiunta
Copy link
Contributor Author

@sindresorhus It's been almost 30 days since this PR was submitted. Over 2 months since this list was created. A good few hours of work put into this list. You've actively given your feedback on far newer PRs. Please review so I can get to fixing whatever issues need to be addressed and it can be merged. Thank you.

@legodude17
Copy link

  • Describe what articles are about
  • Ensure that no descriptions start with A or An
  • Ensure that every description ends in a period
  • Describe the following more fully:
    • Crisp
    • Chatra
    • Olark
    • Drift

@chasegiunta
Copy link
Contributor Author

chasegiunta commented Jul 19, 2017

@legodude17 I really appreciate the review! Good eye. I've addressed 3 of the 4 points you listed:

As for the article descriptions, the titles are descriptions themselves. I believe if I were to try & write additional descriptions, they would be redundant. I hope this practice is okay, as the lists that @sindresorhus maintains himself (and others I've seen) also follow the same format

@legodude17
Copy link

@chasegiunta Yeah, the articles do describe themselves.

readme.md Outdated
@@ -408,6 +408,7 @@
- [Wagtail](https://github.com/springload/awesome-wagtail) - Django CMS focused on flexibility and user experience.
- [Textpattern](https://github.com/drmonkeyninja/awesome-textpattern) - Lightweight PHP-based CMS.
- [Drupal](https://github.com/nirgn975/awesome-drupal) - Extensible PHP-based CMS.
- [Craft CMS](https://github.com/chasegiunta/awesome-craft) - Content-first CMS
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing a . at the end.

@sindresorhus
Copy link
Owner

@chasegiunta Please understand that I have a life outside of this project and open source. It's summer and I've been busy in real life. I have a lot of tabs open with things I need to do, and I don't always do them in order. You have spent a few hours creating your list, but I have spent hundreds of hours on this project.

@sindresorhus
Copy link
Owner

Back to the review:

  • List looks pretty good. Nice work on the header!
  • Links and descriptions should be separated by a -. For example [Title](URL) - Description. (Also note the uppercased first character in the description and it ending in a dot).
  • I'd like to see some links to community resources: Stack Overflow tag, IRC, chat, forums, communities, Reddit, etc. Example: https://github.com/sindresorhus/awesome-electron#community

@chasegiunta
Copy link
Contributor Author

@sindresorhus You're right. My frustration was mainly due to some newer PRs getting attention while this one remained unseen, but nevertheless in the scope of things, my impatience is uncalled for. I appreciate you making time for it!

Made the following changes:

  • I've edited the PR & added a dot to the end of the description (cannot believe I missed that). e02a6d2
  • Links and descriptions should be separated by a '-' craftcms/awesome@a892cb6

So, I only didn't apply the above format (dash to separate, uppercased first character, ending in dot) to the articles. Article Title - By John Doe. doesn't quite sit right with my grammatical brain, yet I think it is beneficial to give the author & agency credit in the listing. If this is okay, great! If not, I'll just remove the descriptive credits.

I did have "Third Party" resources listed at the very bottom, but "Community" better fits that section and encompasses official resources. Added: official Slack group, Twitter, and Facebook Links. There is an unofficial Craft subreddit, but it's not very active, and isn't an awesome resource imo.

@sindresorhus sindresorhus merged commit 79ac104 into sindresorhus:master Jul 24, 2017
@sindresorhus
Copy link
Owner

👍

sfischer13 pushed a commit to sfischer13/awesome that referenced this pull request Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants