Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IT Quotes #903

Merged
merged 4 commits into from
Jun 18, 2017
Merged

Add IT Quotes #903

merged 4 commits into from
Jun 18, 2017

Conversation

victorlaerte
Copy link
Contributor

https://github.com/victorlaerte/awesome-it-quotes

This is an list of awesome IT quotes. The aims is to get together all relevant quotes said over the history of IT. There's no much data yet, but I'm still selecting new ones.

By submitting this pull request I confirm I've read and complied with the below requirements.

Failure to properly do so will just result in the pull request being closed and everyone's time wasted. Please read it twice. Most people miss many things.

  • I have read and understood the contribution guidelines and the instructions for creating a list.
  • This pull request has a descriptive title. For example, Add Name of List, not Update readme.md or Add awesome list.
  • The entry in the Awesome list should include a short description about the list project/theme (not the list itself), and should be added at the bottom of the appropriate category.
  • The list I added
    • has been around for at least 30 days,
    • is the result of hard work and is the best I could possibly produce,
    • is a non-generated Markdown file in a GitHub repo,
    • is not a duplicate,
    • includes a succinct description of the project/theme at the top (example),
    • includes a project logo/illustration (whenever possible) at the top right of the readme (example). (The logo should link to the project website or any relevant website. The logo should be high-DPI, so set it to maximum half the width of the original image.),
    • only has awesome items with descriptions (Awesome lists are curations of the best, not of everything),
    • contains the awesome badge on the right side of the list heading,
    • has a Table of Contents section named Contents as the first section,
    • has an appropriate license (Meaning something like CC0, NOT a code licence like MIT, BSD, Apache, etc) (If you use a license badge, it should be SVG, not PNG),
    • has contribution guidelines,
    • doesn't include a Travis badge,
    • has been checked for inconsistent formatting, spelling, and grammar:
      • Each link description starts with an uppercase character and ends with a period.
      • Drop all the A / An prefixes in the descriptions.
      • Consistent naming. For example, Node.js, not NodeJS or node.js.

@davisonio
Copy link
Contributor

Please read the requirements above - this can be reopened in 30 days and when all above points are met.

@davisonio davisonio closed this Mar 11, 2017
@victorlaerte victorlaerte changed the title Update readme.md Add IT Quotes List Mar 11, 2017
@sindresorhus sindresorhus mentioned this pull request Mar 12, 2017
@victorlaerte
Copy link
Contributor Author

@sindresorhus Sorry about other PR, but I created it because to adjust commit message.
I think all points are now met.

@davisonio
Copy link
Contributor

It hasn't been around for 30 days yet for a start

@victorlaerte
Copy link
Contributor Author

victorlaerte commented Apr 18, 2017

@davisonio Can you reopen now??

@davisonio davisonio reopened this Apr 20, 2017
@sindresorhus sindresorhus mentioned this pull request Apr 21, 2017
@@ -328,6 +328,7 @@ Check out my [blog](https://blog.sindresorhus.com) and follow me on [Twitter](ht
- [Fantasy](https://github.com/RichardLitt/awesome-fantasy)
- [Podcasts](https://github.com/guipdutra/awesome-geek-podcasts)
- [Email Newsletters](https://github.com/vredniy/awesome-newsletters)
- [IT Quotes](https://github.com/victorlaerte/awesome-it-quotes)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry in the Awesome list should include a short description about the list project/theme (not the list itself)

@sindresorhus
Copy link
Owner

If you use a license badge, it should be SVG, not PNG

@victorlaerte
Copy link
Contributor Author

Already done.

@sindresorhus
Copy link
Owner

awesome-it-quotes => Awesome IT Quotes

The badge should be on the right side of the title.

Drop the Awesome image. It's only useful if you actually integrate the list title with the Awesome logo, like https://github.com/vuejs/awesome-vue

The list tagline should be in normal font size and not bold.

Contribution guidelines should be in a separate CONTRIBUTING.md file.

readme.md Outdated
@@ -328,6 +328,7 @@ Check out my [blog](https://blog.sindresorhus.com) and follow me on [Twitter](ht
- [Fantasy](https://github.com/RichardLitt/awesome-fantasy)
- [Podcasts](https://github.com/guipdutra/awesome-geek-podcasts)
- [Email Newsletters](https://github.com/vredniy/awesome-newsletters)
- [IT Quotes](https://github.com/victorlaerte/awesome-it-quotes) - Best IT quotes over the history.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a better description. And Best is already implied. This is an awesome list.

@sindresorhus sindresorhus changed the title Add IT Quotes List Add IT Quotes May 16, 2017
@victorlaerte
Copy link
Contributor Author

All topics of the first comment has been done, but the following one I could not understand.
Which one are you saying?

The list tagline should be in normal font size and not bold.

Quotes ?

or table header?
I looked for the bold markdown tag * * and there's no one in md file.

@sindresorhus
Copy link
Owner

Which one are you saying?

That's because you removed it in victorlaerte/awesome-it-quotes@5355bed#diff-04c6e90faac2675aa89e2176d2eec7d8

You still need a tagline/intro under the list heading. For example: https://github.com/jbmoelker/progressive-enhancement-resources

@victorlaerte
Copy link
Contributor Author

Is it ok now ?

@sindresorhus sindresorhus merged commit 899af7e into sindresorhus:master Jun 18, 2017
rjkmurray added a commit to rjkmurray/awesome that referenced this pull request Jul 2, 2017
parinck pushed a commit to parinck/awesome that referenced this pull request Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants