Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActionScript 3 #1009

Merged
merged 3 commits into from
Jul 23, 2017
Merged

Add ActionScript 3 #1009

merged 3 commits into from
Jul 23, 2017

Conversation

robinrodricks
Copy link

@robinrodricks robinrodricks commented Jul 17, 2017

https://github.com/hgupta9/awesome-actionscript3/

Awesome tools, libraries and components for ActionScript 3 and Adobe AIR.

I have complied with the below requirements:

  1. Created 30+ days ago (Jun 10th). 60 commits. Hand curated.
  2. Result of hard work and truly the best I could make it.
  3. Only has awesome items.
  4. Not a duplicate.
  5. Has a TOC. Well categorized. Has a logo of Flash & AIR on top-right.
  6. All entries have a hand-written description, not just a copy-paste from the project.
  7. All entries are FOSS unless specified in the section heading (only a few tools are Commercial)
  8. Has consistent formatting
  9. No travis badge in the readme

@sindresorhus
Copy link
Owner

Good job, but many of the requirements are not followed. Read https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md more thoroughly.

@robinrodricks
Copy link
Author

Can you be somewhat more specific? You mean the descriptions need to be cleaned up? The casing? Spacing? What??

@sindresorhus
Copy link
Owner

Just go through each point and check that you've done it.

@robinrodricks
Copy link
Author

Why can't you just specify and make it simpler for both of us? Please? I fixed the license thing.

@robinrodricks
Copy link
Author

What, you want me to take away all the double categories and make it just a single set of categories?

@robinrodricks
Copy link
Author

robinrodricks commented Jul 18, 2017

Surely done..

  • Has been around for at least 30 days.
  • That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • It's the result of hard work and the best I could possibly produce.
  • Non-generated Markdown file in a GitHub repo.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Includes a project logo/illustration whenever possible.
  • Placed at the top-right of the readme. (Example)
  • The image should link to the project website or any relevant website.
  • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Has the Awesome badge on the right side of the list heading,
  • Has a Table of Contents section.
  • Should be named Contents, not Table of Contents.
  • Should be the first section in the list.
  • Has an appropriate license.
  • That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
  • Has contribution guidelines.
  • The file should be named contributing.md. Casing is up to you.
  • Doesn't include a Travis badge.

Possible issues??

  • Should only have one level of sub-lists, preferably none.
  • Has consistent formatting and proper spelling/grammar.
  • Each link description starts with an uppercase character and ends with a period.
  • Example: - AVA - JavaScript test runner.
  • Drop all the A / An prefixes in the descriptions.
  • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

@Jogai
Copy link

Jogai commented Jul 18, 2017

Why can't you just specify and make it simpler for both of us? Please? I fixed the license thing.

Maintaining is a lot of work. He has no time to point out the issues for every pr.

@sindresorhus
Copy link
Owner

Why can't you just specify and make it simpler for both of us? Please? I fixed the license thing.

No, it makes it simpler for you. I've spent an enormous amount of time on the contributing guidelines so I won't have to comment the same thing on each PR, but that ends up just being a waste of time when nobody bothers to actually read it thoroughly...

What, you want me to take away all the double categories and make it just a single set of categories?

No, just in the Table of Contents. The TOC doesn't need to list every sub-section, just the main ones.


Missing things from the guidelines:

Has the Awesome badge on the right side of the list heading,


The entry in the Awesome list should: Include a short description about the project/theme of the list. It should not describe the list itself.
Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..


Includes a succinct description of the project/theme at the top of the readme. (Example)


Heading: awesome-actionscript3 => Awesome ActionScript 3


The image should be high-DPI. Set it to maximum half the width of the original image.


Each link description starts with an uppercase character and ends with a period.

@sindresorhus
Copy link
Owner

Many of the descriptions starts with AS3, but that is moot as it's implied.

@robinrodricks
Copy link
Author

Thank you for replying!!

@robinrodricks
Copy link
Author

Done.

  • The TOC doesn't need to list every sub-section, just the main ones.
  • Has the Awesome badge on the right side of the list heading
  • Includes a succinct description of the project/theme at the top of the readme
  • Heading: awesome-actionscript3 => Awesome ActionScript 3
  • The image should be high-DPI. Set it to maximum half the width of the original image.

Not done.

The entry in the Awesome list should: Include a short description about the project/theme of the list.

Most of the other languages don't have a description (eg JS, .NET) so I followed that scheme. AS3 is a very wide language like .NET, meaning you can build apps, games, libs and whatnot so I cannot possibly summarize it in 5 words. I hope thats ok.

In progress

Each link description starts with an uppercase character and ends with a period.

@robinrodricks
Copy link
Author

robinrodricks commented Jul 18, 2017

All done.

  • Each link description starts with an uppercase character and ends with a period.
  • Many of the descriptions starts with AS3, but that is moot as it's implied.

@sindresorhus
Can you check if it meets your standards?

https://github.com/hgupta9/awesome-actionscript3/

@robinrodricks
Copy link
Author

@sindresorhus
Are there any more issues with this?

@sindresorhus
Copy link
Owner

Linkify ActionScript 3 and Adobe AIR in the readme description to their Wikipedia pages.


Most of the other languages don't have a description (eg JS, .NET) so I followed that scheme. AS3 is a very wide language like .NET, meaning you can build apps, games, libs and whatnot so I cannot possibly summarize it in 5 words. I hope thats ok.

Can simply be something like:

Object-oriented language targeting Adobe AIR.

@robinrodricks
Copy link
Author

Done.

  • Linkify ActionScript 3 and Adobe AIR in the readme description to their Wikipedia pages.
  • Object-oriented language targeting Adobe AIR.

Can you merge it now?

@sindresorhus sindresorhus merged commit 522ea8e into sindresorhus:master Jul 23, 2017
@robinrodricks
Copy link
Author

Thank you!

sfischer13 pushed a commit to sfischer13/awesome that referenced this pull request Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants