Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Union Error Emit Order #375

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Union Error Emit Order #375

merged 2 commits into from
Apr 10, 2023

Conversation

sinclairzx81
Copy link
Owner

@sinclairzx81 sinclairzx81 commented Apr 10, 2023 •
edited
Loading

This PR changes the union error emit order to yield the union before variant errors. As noted on #374, excessive error generation can be a problem for large unions. By emitting the union error first, subsequent sub schema errors can be discarded by checking a cached union path property.

@sinclairzx81 sinclairzx81 merged commit 39fccd5 into master Apr 10, 2023
@sinclairzx81 sinclairzx81 deleted the union branch April 10, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sinclairzx81