Security upgrade for docker node image #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN11-ZLIB-6008961 - https://snyk.io/vuln/SNYK-DEBIAN11-SYSTEMD-6277510 - https://snyk.io/vuln/SNYK-DEBIAN11-SYSTEMD-6277510 - https://snyk.io/vuln/SNYK-DEBIAN11-GLIBC-531492 - https://snyk.io/vuln/SNYK-DEBIAN11-GLIBC-532215
Security upgrade node from 18-bullseye-slim to 22.1-bookworm-slim +
|
also add |
|
Nice catch, also added in devcontainer dockerfile |
sinamics
approved these changes
May 25, 2024
prisma/schema.prisma
Outdated
Comment on lines
6
to
7
| //binaryTargets = ["native", "debian-openssl-1.1.x", "linux-arm64-openssl-1.1.x"] | ||
| binaryTargets = ["native", "debian-openssl-1.1.x" ,"debian-openssl-3.0.x", "linux-arm64-openssl-1.1.x"] |
There was a problem hiding this comment.
could we remove both 1.1.x version and also add linux-arm64-openssl-3.0.x
binaryTargets = ["native", "debian-openssl-3.0.x", "linux-arm64-openssl-3.0.x"]I just tested arm64 build with 3.0, and it works just fine.
|
Thank you for the contribution ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a Snyk scan of the repo, vulnerabilities in the debian node docker image.
Bumped the version to node:22.1-bookworm-slim.
The schema.prisma file has been updated to include "debian-openssl-3.0.x" in the binaryTargets configuration. This ensures that the Prisma Client generates the necessary binaries for the correct OpenSSL version following the image upgrade.
Tested deployment on Debian 11 with Docker Engine - Community Version 26.0.1, API version 1.45