Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

اضافه شدن فیچر های جدید #27

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

miladshakerdn
Copy link

@miladshakerdn miladshakerdn commented Nov 11, 2021

نیازمندی ‌جدید

نیاز به نصب نسخه سیستمی ffmpeg

تغییرات

1. اضافه شدن صوت به ویدئو ها
2. دسته بندی صوت‌های بدون ویدئو
3. ویدئو ها و صوت‌ها به ترتیب زمانی شماره گذاری شده اند
4. شناسایی و حذف فایل های صوتی خراب

Capture

miladshakerdn and others added 6 commits November 11, 2021 13:30
Check audio is health (fix bug)
slpit audios ( Sounds cut based on video file )
Added audios to videos file with local ffmpeg
Add new tools in tools.py
تایم لاین داخل شرط قرار گرفت
@sina-rostami
Copy link
Owner

سلام خیلی ممنون از شما
به زودی بررسی می‌کنم

@miladshakerdn
Copy link
Author

سلام، لطفا دارید. اگر وقت کردم این نیاز به نصب نسخه سیستمی ffmpeg رو رفع میکنم. ولی این درس‌هام خیلی سنگین شده این ترم، خیلی اذیت میکنه...
چندتا فیچر جدید هم درنطر دارم، که مثلا خود کاربر میزان تقویت صدا رو تعیین کنه و صدای استاد درس نسبت به صدای سایرین بیشتر تقویت بشه.
و اینکه شاید زیرنویس برای فیلم‌ها هم ایجاد کنم، منظورم اون قسمتی هست که بچه‌ها تکست میفرستند و اون متن داخل ویدئو نشون داده بشه.
یک بخش هم برای نصب خودکار پیش‌نیازهای پایتون

Copy link
Owner

@sina-rostami sina-rostami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also rebase your branch with master

return time_slice

def audios_splitter(targetAudio,time_box,output_path,format=".mp3"):
output_path = output_path.replace("\\","/")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to this

removefile(targetVideo)


def timeLine(time_table, time_Lines, meeting = "sample"):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use snake_case convention

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in other functions and vars

@@ -2,70 +2,68 @@
import xmltodict
import os
import re

import tools as milad # Miladshakerdn => Github
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a proper name :)

aud = ffmpeg.input(meeting_temp_path + camera_voip).audio
audios.append(ffmpeg.filter(aud, 'adelay', '{}ms'.format(time_table[camera_voip][0])))
target_audio_path = meeting_temp_path + camera_voip
prop = len(ffmpeg.probe(meeting_temp_path + camera_voip)['streams'])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prop = len(ffmpeg.probe(meeting_temp_path + camera_voip)['streams'])
probe_len = len(ffmpeg.probe(meeting_temp_path + camera_voip)['streams'])

milad.audios_splitter(targetAudio, time_box, output_path)

videos = []
prev_scrnshr = ""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prev_scrnshr = ""
prev_screen_share = ""

for iname in time_box:
if str(iname).startswith(vTemp):
video_name = iname
targetAudioV = video_name + ".mp3"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use snake_case convention


def convert_media(meeting_id):
# for debugging change from 'quiet' to 'info'
log_level = 'quiet'

# Sound volume 0-100
volume = 100
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes the sound very noisy, I think we don't need this at least for now

@sina-rostami
Copy link
Owner

sound of screen shares is not sync with the video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants