fix: Preserve the original slice when removing string (argoproj#4835)

Signed-off-by: songjuchao <[email protected]>
simster7 · Jan 7, 2021 · 53110b6 · 53110b6
1 parent adfa988
commit 53110b6
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/util/slice/slice.go b/util/slice/slice.go
@@ -3,7 +3,9 @@ package slice
 func RemoveString(slice []string, element string) []string {
  for i, v := range slice {
  if element == v {
- return append(slice[:i], slice[i+1:]...)
+ ret := make([]string, 0, len(slice)-1)
+ ret = append(ret, slice[:i]...)
+ return append(ret, slice[i+1:]...)
  }
  }
  return slice