-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule::loadFromString cannot handle DTSTART/DTEND with timezones #137
Labels
Comments
ftcvlad
added a commit
to ftcvlad/recurr
that referenced
this issue
Jun 8, 2020
RFC compliance and fixes for issue simshaun#137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
because loadFromString actually makes a explode(';') to create an array for loadFromArray, timezones are broken here, e.g.:
This is not covered by the unittest :(
I suggest to extend each test to be sure that results from getString() can always be used to recreate the object and both are equal:
Similar problem is, that you can control, to add/remove DTSTART for the rules, but not DTEND, so this also is not predictable, this test fails also:
But this has a total different behaviour:
Here we don't get any DTEND, because of
This should check for DateTimeInterface I guess.
Thanks for your work, best regards
Gregor
The text was updated successfully, but these errors were encountered: