This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Open handler checks if view is not already open #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can reproduce this and verified the messy state is no longer the case after the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sometimes get a weird error that says "failed to rename buffer" and then symbols-outline opens multiple windows and runs into a bad state. I reproduced it a few times when I pressed the keybinding to open before the LSP is ready and then the handler gets called multiple times. After this change and spamming the keybinding I can no longer reproduce this issue symbols-outline.
I don't know if that's sufficient detail to accept this change and whether you will be able to reproduce this edge case but according to the handler implementation it seems like it's always a bad idea to call it when the outline is already open and even without reproduction it makes sense to check it rather than get into this bad state.