Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Do not close outline when focus_location occurs #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

M1Sports20
Copy link

When auto_close is set to false, this patch does nothing.
However, when auto_close is set to true now the outline only closes when
the goto_location action is taken. The action focus_location still
keeps the outline open.

When auto_close is set to false, this patch does nothing.
However, when auto_close is set to true now the outline only closes when
the goto_location action is taken.  The action focus_location still
keeps the outline open.
@M1Sports20
Copy link
Author

I feel like the default behavior is wrong when auto_close is set to false.
Currently when auto_close is set to false both actions focus_location('o') and goto_location('') do the same thing. Maybe i am misunderstanding, but I feel like focus should keep the outline open and can be used to "browse the code" while goto_location can be used to jump to the location.

hedyhli added a commit to hedyhli/outline.nvim that referenced this pull request Nov 1, 2023
hedyhli added a commit to hedyhli/outline.nvim that referenced this pull request Nov 2, 2023
simrat39/symbols-outline.nvim#119

Rather than using another config option, this should be the default,
expected behaviour for auto_preview.

Also (another difference to the PR implementation is that) there is no
need to subscribe to both CursorHold and CursorMoved.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant