-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CKEditor Icon #11274
base: develop
Are you sure you want to change the base?
Add CKEditor Icon #11274
Conversation
I think we should use the icon from website header for CKEditor instead of |
We already have CKEditor4 and this is what looks like: #5159 I was just going based off this 🤷♂️ |
In my opinion, we may not need a unique icon for every version, especially when the only difference is a number. |
This comment was marked as outdated.
This comment was marked as outdated.
|
That the logo should be that with a number, I got the actual logo from HERE |
From https://ckeditor.com/legal/:
I don't think we can include this without first requesting permission. Would you mind reaching out @jrhaberland? |
Sent an email to CKSource I'll also need to go back and remove the license I added. Since the license of the GitHub repo only covers the code not the logo |
Amazing thank you! |
Now, not knowing the software - please excuse my ignorance. |
I mean I'm just going with the existing precedent that we already have a versioned CKEditor4 icon, and we have other examples that I've pointed out earlier in this thread that are versioned products/software. |
Most of the others (Playstation, Windows) are kept for archival purposes (plus some people still use / develop for them), hence why we re-added Stadia even though it's a dead brand. CKEditor5 is a lot closer to the Affinity icons, in that it seems like a direct replacement of CKEditor4 though - I can't see anywhere that there is a market of people developing / working with 4 still, and the brand of CKEditor has it's own logo outside of the 'product' icon. I'd argue we should instead change the existing CKEditor4 logo to be the one found in the website header and not look to include 5. |
@adamrusted I can go ahead and do that in here, or I can make a new pull request for that change if you think that's more proper |
If you could, @jrhaberland - that'd be great. If you wanted to re-tool this PR to just add CKEditor as it's own thing - and we'll start another PR for the removal of 4 as of October. |
@adamrusted completed changing it from CKEditor 5 to being just the overall CKEditor logo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icon and metadata look good! Last remaining issue is what we should do with the existing ckeditor4
icon? Remove it in the next major update?
Yeah just remove them in the v14 update. We also still need to wait for permission before merging this, I still have yet to hear back from them, but I'll go ahead and send a follow up email. |
Issue: closes #8293
Popularity metric:
The Similarweb rank is 139,593. See https://www.similarweb.com/website/ckeditor.com/
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Adds main logo for CKEditor the overall company. Color is
#771BFF