Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DocuSign icon #11232

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Remove DocuSign icon #11232

wants to merge 4 commits into from

Conversation

anhthang
Copy link
Contributor

@anhthang anhthang commented Jun 16, 2024 •
edited

image

Issue: closes #11230

Popularity metric:

Global Rank 1,229

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@simple-icons simple-icons bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jun 16, 2024
@uncenter
Copy link
Member

It also looks like there brand name is (now?) "Docusign" (lowercase S). Would you mind updating @anhthang?

uncenter
uncenter requested changes Jun 16, 2024
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
@anhthang anhthang requested a review from uncenter June 16, 2024 02:27
uncenter
uncenter requested changes Jun 16, 2024
View reviewed changes
icons/docusign.svg Outdated Show resolved Hide resolved
@anhthang anhthang requested a review from uncenter June 16, 2024 02:39
@adamrusted
Copy link
Member

adamrusted commented Jun 16, 2024 •
edited

Page 27 of this document states:

You may not ... distribute or otherwise make available our logos, marks, or assets

We will therefore need to remove Docusign from the collection. Did you want to re-tool this PR for that, @anhthang - or do you want to close and we'll sort removal elsewhere?

@anhthang
Copy link
Contributor Author

@adamrusted you wanna convert this PR to removal, right?

@adamrusted
Copy link
Member

Yeah, was just asking if you were okay to do the removal in this PR or whether you wanted us to close this, and remove it elsewhere.

@anhthang anhthang changed the title Update DocuSign icon Remove DocuSign icon Jun 16, 2024
@anhthang
Copy link
Contributor Author

No problem, I've removed the icon and updated the PR title for clarity.

@adamrusted adamrusted added breaking change Issues or pull requests that include a breaking change and scheduled for the next major release and removed update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both labels Jun 16, 2024
@adamrusted adamrusted added this to the v13.0.0 milestone Jun 16, 2024
@adamrusted
Copy link
Member

Awesome, thanks @anhthang - we've got a release at the end of this month (Microsoft removal) so can look to include there :)

@adamrusted adamrusted marked this pull request as draft June 16, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncenter uncenter Awaiting requested review from uncenter

Assignees
No one assigned
Labels
breaking change Issues or pull requests that include a breaking change and scheduled for the next major release
Projects
None yet
Milestone
v13.0.0
Development

Successfully merging this pull request may close these issues.

Update: DocuSign
3 participants
@anhthang @uncenter @adamrusted