Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filament icon #11032

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add Filament icon #11032

wants to merge 5 commits into from

Conversation

anhthang
Copy link
Contributor

@anhthang anhthang commented May 27, 2024

image

Issue: closes #10344

Popularity metric:

GitHub Repo stars

The similar web rank is 80,339. See https://www.similarweb.com/website/filamentphp.com/#overview

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG and hex value #fdae4b extracted from the website

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label May 27, 2024
@uncenter uncenter changed the title Add Filament Add Filament icon May 27, 2024
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing slight differences all over. Try increasing the precision when optimizing?

Screenshot 2024-05-27 at 12 02 22 (Inkscape)

@anhthang anhthang requested a review from uncenter May 28, 2024 03:01
@anhthang
Copy link
Contributor Author

Just checked #10344, what do you guys think about using fi only as the favicon

@adamrusted
Copy link
Member

I'd be happy just using the fi as the icon - but would suggest we use the full title as the source as it's a tidier SVG!

@adamrusted
Copy link
Member

Just a reminder @anhthang - did you want to go with just the fi icon here?

@anhthang
Copy link
Contributor Author

@adamrusted fi looks better, but Filament seems to be their standard across social media. I think maintaining that consistency is more important.

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as this is a large SVG and I'm seeing quite a lot of unnecessary/duplicate nodes (not your fault ahah, just the way the original SVG is), I think it is worth trying to remove some of the ones that aren't affecting the shape. Could you give that a try @anhthang? I usually duplicate the path in my editor, and put one on the bottom with a red fill so I can easily see if deleting a node caused the red to become visible (meaning I can't delete that node since it changes the shape). Other than that though the SVG is a perfect match!

@anhthang
Copy link
Contributor Author

@uncenter I have tried to remove a lot of nodes. Would you like to review again?

@anhthang anhthang requested a review from uncenter June 21, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: FilamentPHP
3 participants