Set font in <div> instead of <a>

[jplitza]

Otherwise a parent's font declaration may lead to the .github-fork-ribbon being too big.

[simonwhitaker]

Hi @jplitza, thanks for the contribution. Can you just explain (to this not-very-good-at-web-dev dummy) how the bug this fixes could occur please? Perhaps by way of an example.

[aik099]

Maybe if the rem or % measure units are used to set font-size on the page, where ribbon is used.

Just a guess.

[jplitza]

See this jsfiddle where I exaggerated and set body's font-size to 40pt. The red border around the link is much too big.

@aik099 Nope, no crazy relative units are needed, just normal absolute ones.

[aik099]

And with this font size moved to div instead of A all is fine, right?

[jplitza]

Yes, it is. I updated the jsfiddle to show one working and one non-working example.

[aik099]

Thanks. As ribbon user (see http:https://www.qa-tools.io/) I think the change should be merged.

[simonwhitaker]

Thanks @jplitza, much appreciated. 😄