Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license comments #29

Merged
merged 1 commit into from
Jun 10, 2014
Merged

Add license comments #29

merged 1 commit into from
Jun 10, 2014

Conversation

shinnn
Copy link
Contributor

@shinnn shinnn commented May 12, 2014

When we use CSS compressors such as clean-css, we can preserve license comments wrapped with /*! ... */.

simonwhitaker added a commit that referenced this pull request Jun 10, 2014
@simonwhitaker simonwhitaker merged commit e39ddcb into simonwhitaker:gh-pages Jun 10, 2014
@simonwhitaker
Copy link
Owner

Thanks! (Just found this in my PR queue, I'd managed to miss it. Sorry it took so long to merge.)

@shinnn
Copy link
Contributor Author

shinnn commented Jun 10, 2014

No problem!
And, I'll be glad if you publish the new release (maybe, a patch release v0.1.1) for Bower.

@simonwhitaker
Copy link
Owner

@shinnn No problem. Do I just need to update the version number(s) in the repo, or is there something I need to do at Bower's end, do you know? (I don't use Bower, support for it was added by another of this repo's many awesome contributors. 😄)

@simonwhitaker
Copy link
Owner

Looks like just updating the repo is enough.

$ bower info github-fork-ribbon-css                  
bower github-fork-ribbon-css#*  cached git:https://github.com/simonwhitaker/github-fork-ribbon-css.git#1.0.0
bower github-fork-ribbon-css#*         validate 1.0.0 against git:https://github.com/simonwhitaker/github-fork-ribbon-css.git#*
bower github-fork-ribbon-css#*              new version for git:https://github.com/simonwhitaker/github-fork-ribbon-css.git#*
bower github-fork-ribbon-css#*          resolve git:https://github.com/simonwhitaker/github-fork-ribbon-css.git#*
bower github-fork-ribbon-css#*         download https://github.com/simonwhitaker/github-fork-ribbon-css/archive/0.1.1.tar.gz
bower github-fork-ribbon-css#*          extract archive.tar.gz
bower github-fork-ribbon-css#*         resolved git:https://github.com/simonwhitaker/github-fork-ribbon-css.git#0.1.1

{
  name: 'github-fork-ribbon-css',
  version: '0.1.1',
  homepage: 'http:https://simonwhitaker.github.io/github-fork-ribbon-css/',
  authors: [
    'Simon Whitaker'
  ],
  description: '"Fork me on GitHub" CSS ribbon',
  main: [
    'gh-fork-ribbon.css',
    'gh-fork-ribbon.ie.css'
  ],
  keywords: [
    'css',
    'fork',
    'GitHub',
    'ribbon'
  ],
  license: 'MIT',
  ignore: [
    '**/.*',
    'node_modules',
    'bower_components',
    'test',
    'tests'
  ]
}

Available versions:
  - 0.1.1
  - 0.1.0

You can request info for a specific version with 'bower info github-fork-ribbon-css#<version>'

Cool! 😄

@shinnn
Copy link
Contributor Author

shinnn commented Jun 10, 2014

Great!
Thanks for merging and quick release.

@shinnn shinnn changed the title Add license comment Add license comments Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants