Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSS standard declaration for the linear gradient on line 18 #28

Merged
merged 1 commit into from
Mar 21, 2014

Conversation

kmp1
Copy link
Contributor

@kmp1 kmp1 commented Mar 21, 2014

Firstly, this is kind of trivial, sorry for that, I love your CSS ribbon and I suppose I'm "building a shed" here but pressing on regardless...

So I was browsing a web site using Firefox that used your fork me on github ribbon and I noticed that I got CSS errors on lines 13, 14, 16, 17 and 18 of the gh-fork-ribbon.css file. Looking at the file I see that you're handling all the browser variations and that, since I was using Firefox, the one that matched was line 15 (-moz-linear etc). So I was about to not worry about it since that is fine, of course, but the last error concerned me (line 18), specifically the error was:

Expected color but found 'top'.  Error in parsing value for 'background-image'.  Declaration dropped.

So, I think your intention was that this should be the CSS standard approach but I think it is not quite correct (not that it really matters as I think every browser will just pick one of the preceeding background images regardless - I said this was trivial right?). Looking at the Linear Gradient documentation I notice that the syntax is:

linear-gradient(  [ <angle> | to <side-or-corner> ,]? <color-stop> [, <color-stop>]+ )

So I think that that line should be changed to what I attach here as a pull request, specifically:

background-image: linear-gradient(to bottom, rgba(0, 0, 0, 0), rgba(0, 0, 0, 0.15));

This will make the gradient from the top to the bottom, completely transparent to slightly transparent black as per your comment in said file.

@simonwhitaker
Copy link
Owner

Thanks for this! 😄

simonwhitaker added a commit that referenced this pull request Mar 21, 2014
Use CSS standard declaration for the linear gradient on line 18
@simonwhitaker simonwhitaker merged commit fef29b1 into simonwhitaker:gh-pages Mar 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants