Use CSS standard declaration for the linear gradient on line 18 #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, this is kind of trivial, sorry for that, I love your CSS ribbon and I suppose I'm "building a shed" here but pressing on regardless...
So I was browsing a web site using Firefox that used your fork me on github ribbon and I noticed that I got CSS errors on lines 13, 14, 16, 17 and 18 of the gh-fork-ribbon.css file. Looking at the file I see that you're handling all the browser variations and that, since I was using Firefox, the one that matched was line 15 (-moz-linear etc). So I was about to not worry about it since that is fine, of course, but the last error concerned me (line 18), specifically the error was:
So, I think your intention was that this should be the CSS standard approach but I think it is not quite correct (not that it really matters as I think every browser will just pick one of the preceeding background images regardless - I said this was trivial right?). Looking at the Linear Gradient documentation I notice that the syntax is:
So I think that that line should be changed to what I attach here as a pull request, specifically:
This will make the gradient from the top to the bottom, completely transparent to slightly transparent black as per your comment in said file.