llm.user_dir() should create it if it doesn't exist yet

[simonw]

Just fixed this bug:

• Error if io.datasette.llm folder does not exist yet llm-sentence-transformers#9

The code in question did this:

 def register(name, aliases, lazy): 
     sentence_transformers_path = llm.user_dir() / "sentence-transformers.json" 
     if not sentence_transformers_path.exists(): 
         sentence_transformers_path.write_text("[]", "utf-8") 
     current = json.loads(sentence_transformers_path.read_text("utf-8")) 

It worked if llm.user_dir() already existed but failed otherwise.

Maybe llm.user_dir() should create the directory if it's missing before returning it?

[simonw]

Current implementation:

llm/llm/__init__.py

Lines 188 to 192 in 4711336

	def user_dir():
	llm_user_path = os.environ.get("LLM_USER_PATH")
	if llm_user_path:
	return pathlib.Path(llm_user_path)
	return pathlib.Path(click.get_app_dir("io.datasette.llm"))

[simonw]

I think it should create the directory. I think it's a reasonable API expectation for a plugin that the folder returned by llm.user_dir() should exist and not need to be created.