Add sync version

README.md

@@ -22,6 +22,14 @@ svg2png(sourceBuffer, { width: 300, height: 400 })
 
 This is especially useful for images without `width` or `height`s. You can even specify just one of them and (if the image has an appropriate `viewBox`) the other will be set to scale.
 
+## Sync variant
+
+There's also a sync variant, for use in your shell scripts:
+
+```js
+const outputBuffer = svg2png.sync(sourceBuffer, optionalWidthAndOrHeight);
+```
+
 ## How the conversion is done
 
 svg2png is built on the latest in [PhantomJS](http:https://phantomjs.org/) technology to render your SVGs using a headless WebKit instance. I have found this to produce much more accurate renderings than other solutions like GraphicsMagick or Inkscape. Plus, it's easy to install cross-platform due to the excellent [phantomjs](https://npmjs.org/package/phantomjs) npm package—you don't even need to have PhantomJS in your `PATH`.

lib/svg2png.js

@@ -15,10 +15,12 @@ module.exports = (sourceBuffer, resize) => {
  return cp.promise.then(processResult);
 };
 
-// TODO: not sure what execFileSync returns?!
-// module.exports.sync = (sourceBuffer, resize) => {
-// return processResult(childProcess.execFileSync(phantomJsCmd, getPhantomJSArgs(sourceBuffer, resize)));
-// }
+module.exports.sync = (sourceBuffer, resize) => {
+ const result = childProcess.spawnSync(phantomjsCmd, getPhantomJSArgs(resize), {
+ input: sourceBuffer.toString("base64")
+ });
+ return processResult(result);
+}
 
 function getPhantomJSArgs(resize) {
  return [

test/integration.js

@@ -24,13 +24,38 @@ function successTest(test, index) {
  });
 }
 
+function successTestSync(test, index) {
+ specify(test.name, () => {
+ const input = fs.readFileSync(relative(`inputs/${test.file}`));
+ const expected = fs.readFileSync(relative(`success-tests/${index}.png`));
+
+ const output = svg2png.sync(input, test.resize);
+ output.should.deep.equal(expected);
+ });
+}
+
 function failureTest(test) {
- specify(`(negative test) ${test.name}`, () => {
+ specify(test.name, () => {
  const input = fs.readFileSync(relative(`inputs/${test.file}`));
 
  return svg2png(input, test.resize).should.be.rejectedWith(/width or height/i);
  });
 }
 
-successTests.forEach(successTest);
-failureTests.forEach(failureTest);
+function failureTestSync(test) {
+ specify(test.name, () => {
+ const input = fs.readFileSync(relative(`inputs/${test.file}`));
+
+ (() => svg2png.sync(input, test.resize)).should.throw(/width or height/i);
+ });
+}
+
+describe("async", () => {
+ describe("should fulfill", () => successTests.forEach(successTest));
+ describe("should reject", () => failureTests.forEach(failureTest));
+});
+
+describe("sync", () => {
+ describe("should return", () => successTests.forEach(successTestSync));
+ describe("should throw", () => failureTests.forEach(failureTestSync));
+});

test/success-tests/rebaseline.js

@@ -9,7 +9,6 @@ function relative(relPath) {
  return path.resolve(__dirname, relPath);
 }
 
-// TODO do this all sync maybe
 tests.forEach((test, index) => {
  fs.readFile(relative(`../inputs/${test.file}`))
  .then(input => svg2png(input, test.resize))