feat: support containerless rehydration #48
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: rehydrateChildren now returns an object containing 'container' and 'rehydrated' BREAKING CHANGE: data-rehydratable must now match the rehydrator key provided in 'rehydrators'
This was referenced Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implements support for containerless rehydration. Instead of
You can now have
How?
It does this by:
rehydratorsobject to query select alldata-rehydratabletagsBreaking changes
It also introduces two breaking changes:
rehydrateChildrennow returns an object containingcontainerandrehydrateddata-rehydratablemust now match the rehydrator key provided inrehydratorsThe first of the two is perhaps not necessary, but I can't quite remember the behaviour of
rehydrateChildren. It may be possible to avoid a breaking change to this, and instead just implement the container swizzle a layer above.TODO
Aside
My goal is to eliminate any markup delta entirely by optionally supporting class names instead of
data-rehydratable, but this has some performance considerations I need to hash out.I'm also aware that you may have reasons other than those we have already discussed for wanting a container, so feel free to throw this back in my face.