Skip to content

Commit

Permalink
Update helm docs to be more clear for EKS (sourcegraph#47811)
Browse files Browse the repository at this point in the history
## Test plan

* Tested Doc changes by deploying and following steps, then
troubleshooting issues and adding solutions to default
suggestions/information on necessary changes
* Only Doc changes, no code change

<!-- All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles
-->
  • Loading branch information
scjohns committed Feb 21, 2023
1 parent 9d4d2cd commit 2dd4394
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions doc/admin/deploy/kubernetes/helm.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ Our Helm chart has a lot of sensible defaults baked into the values.yaml. Not on

1. Prepare any required customizations
- Most environments are likely to need changes from the defaults—use the guidance in [Configuration](#configuration).
1. Review the changes
- These changes are inclusive of updates to resourcing for each service. See our [resource estimator](../resource_estimator.md) for more information.
2. Review the changes
- There are [three mechanisms](#reviewing-changes) that can be used to review any customizations made, this is an optional step, but may be useful the first time you deploy Sourcegraph, for peace of mind.
1. Select your deployment method and follow the guidance:
3. Select your deployment method and follow the guidance:
- [Google GKE](#configure-sourcegraph-on-google-kubernetes-engine-gke)
- [AWS EKS](#configure-sourcegraph-on-elastic-kubernetes-service-eks)
- [Azure AKS](#configure-sourcegraph-on-azure-managed-kubernetes-service-aks)
Expand Down Expand Up @@ -610,6 +611,9 @@ frontend:
ingress:
enabled: true
annotations:
alb.ingress.kubernetes.io/target-type: ip # specifies targeting services with type ClusterIP
# By default the AWS ALB will be internal to your VPC.
# alb.ingress.kubernetes.io/scheme: internet-facing # use this annotation if you plan to provision a public Sourcegraph URL.
kubernetes.io/ingress.class: alb # aws load balancer controller ingressClass name
# additional aws alb ingress controller supported annotations
# ...
Expand Down

0 comments on commit 2dd4394

Please sign in to comment.