win32: Added Powershell way, WMIC still works #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickriva
commented
Feb 16, 2022
| const gateways = (gwArr.match(/"(.+?)"/g) || []).map(match => match.substring(1, match.length - 1)); | ||
| let finalGwArr = gwArr; | ||
| if (command === "powershell") { | ||
| finalGwArr = `{ ${gwArr.replace(/[{}]/g, "").split(", ").map((value) => `"${value}"`).join(", ")} }`; |
There was a problem hiding this comment.
Powershell table doesn't show IP's between " ". Added it for powershell only. I can't find a better way.
erickriva
commented
Feb 16, 2022
| function parseIfTable(ifTable) { | ||
| const line = (ifTable || "").trim().split("\n")[1]; | ||
| function parseIfTable(ifTable, command) { | ||
| const line = (ifTable || "").trim().split("\n")[command === "powershell" ? 2 : 1]; |
There was a problem hiding this comment.
Powershell table 2nd line is a separator, like this: ----------
3rd line is the one with info needed.
|
Working fine here (with powershell)
|
|
@silverwind Could you please test and merge this? Thank you @erickriva |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.