Fix #11289: Handle paths with spaces in Silverstripe's sake script

[digitall-it]

Description

Expected Behaviour: vendor/bin/sake should function correctly regardless of where the PHP binary is located, even if the path includes spaces.

Observed Behaviour: If the path to the PHP interpreter contains spaces, the script fails with an error because the path isn’t wrapped in quotes, leading to incorrect parsing of the command.

This fix ensures that all paths in the sake script are properly quoted to handle spaces and other special characters that might appear in directory names.

Manual Testing Steps

1. Place your PHP binary in a path with spaces and set up the environment variable or path accordingly.
2. Run vendor/bin/sake build to ensure it picks up the PHP binary and executes without errors.
3. Check other commands and scenarios where sake is used to ensure no other side effects are introduced by this change.

Issues

• Sake script failure when PHP binary path contains spaces in SilverStripe 5.2.2 #11289

Pull Request Checklist

• The target branch is correct. (Refer to picking the right version)
• All commits are relevant to the purpose of the PR.
• Commit messages follow the commit message guidelines.
• The PR follows our contribution guidelines.
• Code changes follow our coding conventions.
• Changes are covered with tests, or tests are not necessary for this change.
• Documentation is updated where necessary.
• CI checks are green.

Additional Notes

Please review the changes and provide feedback or merge if everything is in order.

Thank you!

[digitall-it]

I suggest revisiting the script to ensure that the use of the new syntax "${@}" instead of the old ${*} does not introduce unintended side effects.

The ${@} syntax, when quoted, ensures each argument is preserved in its entirety, which is crucial for handling paths or options that include spaces. It's important to verify that this change maintains the desired behavior throughout the script.

[maxime-rainville]

Tested it locally and it seems sensible.

I don't know that there's a reasonable way of unit testing this. So I'm happy to merge as is.

The ${@} syntax, when quoted, ensures each argument is preserved in its entirety, which is crucial for handling paths or options that include spaces. It's important to verify that this change maintains the desired behavior throughout the script.

I'm trying to think of a scenario where this could break. Can't think of one off the top of my head.

The fact that this is targeted at the next minor, means we would have a couple months of playing with this to potentially find weird edge cases where $@ would produce a different outcome from $*.

[GuySartorelli]

LGTM. Tested with both php path and project path with spaces, and both work without problems.