-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream objectMode implementation callbacks #39
Comments
@shirouto, thanks for pointing this out. Our lack of a robust test suite is showing here. I think I understand the cause, which I'll explain just for posterity's sake... It looks like Node does some "argument juggling" inside the public-facing I will soon push the new version of this library and include a fix for this. Hopefully I can get that done today. I'll let you know when the PR is out. |
@austindd The new By the way, I appreciate the increased ergonomics of the new |
Thinking a bit more about the new
Am I missing something here? Is there a strong reason for this restriction? |
The
~write
callback forStream.Writable.makeOptionsObjMode
has the wrong number of parameters. Even thoughencoding
is ignored for objectMode, it is still required to be provided or else thecallback
parameter does not make it through.From what I can tell, this issue extends to most callbacks for objectMode.
The text was updated successfully, but these errors were encountered: