Don't block things being deleted. #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `cosigned` webhook to ignore things that are being cleaned up. As resources are cleaned up in Kubernetes (typically things with finalizers), they are first tombstoned by setting `metadata.deletionTimestamp` and once the finalizers have fully executed they are actually deleted. To the webhook, these look like `UPDATE` operations, but are distinguishable because we can check for this field. This also adds unit test coverage for the `duckv1.Pod` and `duckv1.WithPod` wrappers around the core validation and resolution logic. Signed-off-by: Matt Moore <[email protected]>
dlorenc
approved these changes
Sep 26, 2021
mrjoelkamp
pushed a commit
to mrjoelkamp/cosign
that referenced
this pull request
Sep 28, 2021
This changes the `cosigned` webhook to ignore things that are being cleaned up. As resources are cleaned up in Kubernetes (typically things with finalizers), they are first tombstoned by setting `metadata.deletionTimestamp` and once the finalizers have fully executed they are actually deleted. To the webhook, these look like `UPDATE` operations, but are distinguishable because we can check for this field. This also adds unit test coverage for the `duckv1.Pod` and `duckv1.WithPod` wrappers around the core validation and resolution logic. Signed-off-by: Matt Moore <[email protected]> Signed-off-by: Joel Kamp <[email protected]>
mrjoelkamp
pushed a commit
to mrjoelkamp/cosign
that referenced
this pull request
Sep 28, 2021
This changes the `cosigned` webhook to ignore things that are being cleaned up. As resources are cleaned up in Kubernetes (typically things with finalizers), they are first tombstoned by setting `metadata.deletionTimestamp` and once the finalizers have fully executed they are actually deleted. To the webhook, these look like `UPDATE` operations, but are distinguishable because we can check for this field. This also adds unit test coverage for the `duckv1.Pod` and `duckv1.WithPod` wrappers around the core validation and resolution logic. Signed-off-by: Matt Moore <[email protected]> Signed-off-by: Joel Kamp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
cosignedwebhook to ignore things that are being cleaned up.As resources are cleaned up in Kubernetes (typically things with finalizers), they are first tombstoned by setting
metadata.deletionTimestampand once the finalizers have fully executed they are actually deleted.To the webhook, these look like
UPDATEoperations, but are distinguishable because we can check for this field.This also adds unit test coverage for the
duckv1.Podandduckv1.WithPodwrappers around the core validation and resolution logic.Signed-off-by: Matt Moore [email protected]
Ticket Link
Release Note