move verify-dockerfile to dockerfile verify
#662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mattmoor |
Signed-off-by: Jake Sanders <[email protected]>
d71d5c7
to
0905767
Compare
|
/cc @developer-guy |
|
I'm thinking that my concerns about maintainability we'd be taking on by adding new commands and functionality for image discovery would be at least partially ameliorated by formally separating functionality out into different commands. This lets us avoid a situation where we have to support a cross-product of functionality for both a) processing dockerfiles and b) signing/verifying images under a single surface |
mattmoor
reviewed
Sep 14, 2021
| return &ffcli.Command{ | ||
| Name: "dockerfile", | ||
| ShortUsage: "cosign dockerfile", | ||
| ShortHelp: "Provides utilities for attaching artifacts to other artifacts in a registry", |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package dockerfile |
There was a problem hiding this comment.
Thanks for putting this into its own package 🤩 cli is getting crowded
There was a problem hiding this comment.
yeah, been splitting subcommand groups into their own folders
Signed-off-by: Jake Sanders <[email protected]>
priyawadhwa
approved these changes
Sep 14, 2021
mattmoor
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING
This command group lets us begin splitting up image discovery from image signature creation/verification. Another subcommand I'm imagining is:
dockerfile resolve-imageswhich resolvesFROM image:tags toFROM image@sha256:digestand either outputs the list of image digests (e.g. for something likecosign dockerfile resolve-images $FILE | xargs cosign verify) or outputs a re-written file (to STDOUT or in-place).