Support GCP environments without workload identity (GCB). #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
approved these changes
Sep 12, 2021
mattmoor
added a commit
to mattmoor/distroless
that referenced
this pull request
Sep 12, 2021
This refactors the cosign script for distroless, so that the arguments are passed through from `cloudbuild.yaml`, and shifts where `-key ...` is passed to be in `cloudbuild.yaml`. This is preparation to start *also* signing the distroless images with a "keyless" flow, once sigstore/cosign#652 lands and cosign 1.2 cuts.
This requires the use of an environment variable called "GOOGLE_SERVICE_ACCOUNT_NAME" to direct the client on which account to impersonate. Signed-off-by: Dan Lorenc <[email protected]> Signed-off-by: Dan Lorenc <[email protected]>
90de6a0
to
6393129
Compare
mattmoor
approved these changes
Sep 12, 2021
dlorenc
pushed a commit
to GoogleContainerTools/distroless
that referenced
this pull request
Sep 12, 2021
This refactors the cosign script for distroless, so that the arguments are passed through from `cloudbuild.yaml`, and shifts where `-key ...` is passed to be in `cloudbuild.yaml`. This is preparation to start *also* signing the distroless images with a "keyless" flow, once sigstore/cosign#652 lands and cosign 1.2 cuts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires the use of an environment variable called "GOOGLE_SERVICE_ACCOUNT_NAME"
to direct the client on which account to impersonate.
Signed-off-by: Dan Lorenc [email protected]