Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warnings on admissionregistration version #581

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

hectorj2f
Copy link
Contributor

Signed-off-by: Hector Fernandez [email protected]

When installing the helm chart of cosigned, we are seeing some warnings due to the version of the admissionregistration object.

W0826 21:57:01.000200   13246 warnings.go:70] admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration
W0826 21:57:01.219700   13246 warnings.go:70] admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration
NAME: cosigned
LAST DEPLOYED: Thu Aug 26 21:57:00 2021
NAMESPACE: cosigned
STATUS: deployed
REVISION: 1
TEST SUITE: None

@dlorenc
Copy link
Member

dlorenc commented Aug 26, 2021

Any idea what the lint issue is?

@hectorj2f
Copy link
Contributor Author

Let me check it!

Signed-off-by: Hector Fernandez <[email protected]>
@hectorj2f
Copy link
Contributor Author

Helm linting required to bump the Chart version whenever you change files of the Chart.

@cpanato cpanato added this to the v1.2.0 milestone Aug 27, 2021
Copy link
Member

@developer-guy developer-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤝 🥳

@hectorj2f
Copy link
Contributor Author

@cpanato @developer-guy Should we merge this PR ?

@developer-guy developer-guy merged commit fe21c9f into sigstore:main Aug 27, 2021
@developer-guy
Copy link
Member

I think there is a problem with cert-manager helm chart, @hectorj2f would you mind to take a look at the problem ? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants