signing&verifying container images based on Kubernetes Secrets #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #347
Known issues about the implementation:
We duplicated the Kubernetes Client logics (reducing both responsibilities to a single function?)
It's a bit hard to distinguish
namespace/name
compared to other providers (adding a new -k8s flag for signing and verifying)Ref priority refactoring? (File -> KMS -> K8s) - we're checking K8s
namespace/name
in first-order ever since a file exists in that pathWe bring a brand-new
loadPublicKey
function tocli/keys.go
due toimport cycle now allowed
problemWe haven't been checked the values of the data map of the secret whether is nil or not nil.
Use public key as a file