Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump fulcio dep to 0.5.2 #2176

Merged
merged 5 commits into from
Aug 22, 2022
Merged

bump fulcio dep to 0.5.2 #2176

merged 5 commits into from
Aug 22, 2022

Conversation

k4leung4
Copy link
Contributor

@k4leung4 k4leung4 commented Aug 18, 2022

Signed-off-by: Kenny Leung [email protected]

Summary

this updates the fulcio dep from 0.1.2 to 0.5.2.

api.Client => api.LegacyClient

io/ioutil deprecated in go 1.16, use corresponding replacement in io and os

Release Note

NONE

Documentation

@k4leung4 k4leung4 requested a review from cpanato August 18, 2022 16:24
@k4leung4 k4leung4 marked this pull request as draft August 18, 2022 16:51
@k4leung4 k4leung4 removed the request for review from cpanato August 18, 2022 16:51
cpanato
cpanato previously approved these changes Aug 18, 2022
Signed-off-by: Kenny Leung <[email protected]>
Signed-off-by: Kenny Leung <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022

Codecov Report

Merging #2176 (695b2c6) into main (8f29f03) will increase coverage by 0.66%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
+ Coverage   26.03%   26.70%   +0.66%     
==========================================
  Files         131      131              
  Lines        7689     7689              
==========================================
+ Hits         2002     2053      +51     
+ Misses       5445     5375      -70     
- Partials      242      261      +19     
Impacted Files Coverage Δ
.../cosign/cli/fulcio/fulcioverifier/ctutil/ctutil.go 72.36% <ø> (ø)
cmd/cosign/cli/options/registry.go 0.00% <0.00%> (ø)
pkg/cosign/fetch.go 0.00% <0.00%> (ø)
cmd/cosign/cli/fulcio/fulcio.go 18.26% <66.66%> (ø)
pkg/blob/load.go 74.28% <0.00%> (+5.71%) ⬆️
pkg/oci/layout/index.go 28.57% <0.00%> (+28.57%) ⬆️
pkg/oci/layout/write.go 37.50% <0.00%> (+37.50%) ⬆️
pkg/oci/layout/signatures.go 53.84% <0.00%> (+53.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Kenny Leung <[email protected]>
Signed-off-by: Kenny Leung <[email protected]>
@k4leung4 k4leung4 marked this pull request as ready for review August 21, 2022 01:44
@dlorenc dlorenc merged commit 7ba5214 into sigstore:main Aug 22, 2022
@github-actions github-actions bot added this to the v1.12.0 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants