Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a note about SIGSTORE_REKOR_PUBLIC_KEY var #2040

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

hectorj2f
Copy link
Contributor

@hectorj2f hectorj2f commented Jul 1, 2022

Signed-off-by: hectorj2f [email protected]

Summary

I learned this week that SIGSTORE_REKOR_PUBLIC_KEY env variable is used for testing purposes only. So we should add it to the warning and the code docs.

Ticket Link

Fixes

Release Note

Warn when using SIGSTORE_REKOR_PUBLIC_KEY env variable, it is only for testing.

@hectorj2f hectorj2f added the enhancement New feature or request label Jul 1, 2022
@hectorj2f hectorj2f self-assigned this Jul 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #2040 (31c1968) into main (94832ba) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2040   +/-   ##
=======================================
  Coverage   26.22%   26.22%           
=======================================
  Files         128      128           
  Lines        7539     7539           
=======================================
  Hits         1977     1977           
  Misses       5307     5307           
  Partials      255      255           
Impacted Files Coverage Δ
pkg/cosign/tlog.go 30.07% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94832ba...31c1968. Read the comment docs.

@hectorj2f hectorj2f merged commit 1d224d9 into sigstore:main Jul 1, 2022
@hectorj2f hectorj2f deleted the note_rekor_pubkey_env_var branch July 1, 2022 12:29
@github-actions github-actions bot added this to the v1.10.0 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants