Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace gcr.io/distroless/ to use ghcr.io/distroless/ #1961

Merged
merged 4 commits into from
Jun 6, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 5, 2022

Summary

  • replace gcr.io/distroless/ to use ghcr.io/distroless/ for testing

the images from gcr.io/distroless/ (https://github.com/GoogleContainerTools/distroless) are having issues with the signatures and then it is failing our tests, switching to images that we can have a bit more control (https://github.com/distroless/) and act fast in case of any issue.

for building images need a few more tests to check if everything will work as usual

Ticket Link

N/A

Release Note

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2022

Codecov Report

Merging #1961 (815cb52) into main (424f7db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1961   +/-   ##
=======================================
  Coverage   34.71%   34.71%           
=======================================
  Files         153      153           
  Lines       10037    10037           
=======================================
  Hits         3484     3484           
  Misses       6166     6166           
  Partials      387      387           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424f7db...815cb52. Read the comment docs.

Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
@cpanato cpanato requested review from mattmoor and dlorenc June 6, 2022 07:19
@cpanato cpanato marked this pull request as ready for review June 6, 2022 07:20
@cpanato cpanato changed the title [WIP] replace gcr.io/distroless/ to use ghcr.io/distroless/ replace gcr.io/distroless/ to use ghcr.io/distroless/ Jun 6, 2022
@dlorenc
Copy link
Member

dlorenc commented Jun 6, 2022

For context, the gcr images are great but regularly have CI issues that prevent new builds from being fully signed. We've seen this 3-4 times now. The builds aren't viewable or debuggable by people outside the org either.

We only actually use these images in tests, so this is just switching them to another image with a simpler build and test process that's debuggable by the community.

@dlorenc
Copy link
Member

dlorenc commented Jun 6, 2022

Merging to unblock things. We can revisit later if there's a better choice for these tests.

@dlorenc dlorenc merged commit 7bc2145 into sigstore:main Jun 6, 2022
@github-actions github-actions bot added this to the v1.10.0 milestone Jun 6, 2022
@cpanato cpanato deleted the replace-distroless branch June 6, 2022 11:37
@mattmoor
Copy link
Member

mattmoor commented Jun 6, 2022

FWIW we've probably seen this dozens of times, it is just usually transient.

I filed this, which hasn't seen much traction: GoogleContainerTools/distroless#966

We are very intentional about promoting to :latest in github.com/distroless to avoid cases like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants