Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate RegExp matching of issuer/subject from strict #1956

Merged
merged 8 commits into from
Jun 7, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jun 3, 2022

Signed-off-by: Ville Aikas [email protected]

Summary

Add two new fields issuerRegExp and subjectRegExp so that if the user wants RE matching of issuer/subject, it's crystal clear
that RE is being used. issuer / subject are now strict matches only.

Ticket Link

Fixes #1871

Release Note

CIP issuer/subject are now strict matches. Add two new fields issuerRegExp and subjectRegExp that will then use RE for matching.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #1956 (b0124b9) into main (2b4d69b) will increase coverage by 0.18%.
The diff coverage is 95.74%.

@@            Coverage Diff             @@
##             main    #1956      +/-   ##
==========================================
+ Coverage   34.71%   34.90%   +0.18%     
==========================================
  Files         153      153              
  Lines       10037    10057      +20     
==========================================
+ Hits         3484     3510      +26     
+ Misses       6166     6162       -4     
+ Partials      387      385       -2     
Impacted Files Coverage Δ
...g/apis/policy/v1alpha1/clusterimagepolicy_types.go 0.00% <ø> (ø)
...kg/apis/policy/v1beta1/clusterimagepolicy_types.go 0.00% <ø> (ø)
pkg/cosign/kubernetes/webhook/validation.go 74.00% <0.00%> (ø)
...s/policy/v1alpha1/clusterimagepolicy_conversion.go 79.41% <100.00%> (ø)
...s/policy/v1alpha1/clusterimagepolicy_validation.go 94.97% <100.00%> (+1.90%) ⬆️
...is/policy/v1beta1/clusterimagepolicy_validation.go 94.97% <100.00%> (+1.90%) ⬆️
pkg/cosign/verify.go 33.58% <100.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4d69b...b0124b9. Read the comment docs.

hectorj2f
hectorj2f previously approved these changes Jun 6, 2022
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaikas vaikas changed the title WIP: Separate RE matching of issuer/subject from strict Separate RegExp matching of issuer/subject from strict Jun 7, 2022
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaikas vaikas merged commit d14e774 into sigstore:main Jun 7, 2022
@vaikas vaikas deleted the issue-1871 branch June 7, 2022 08:40
@github-actions github-actions bot added this to the v1.10.0 milestone Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosigned policies interpreted as regex by default
3 participants