Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix directory not found error #1718

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

hectorj2f
Copy link
Contributor

Signed-off-by: hectorj2f [email protected]

Summary

make policy-webhook was compiling a wrong directory. I also added the compilation of the policy-webhook binary to the cosigned target.

CGO_ENABLED=0 go build -trimpath -ldflags "-buildid= -X sigs.k8s.io/release-utils/version.gitVersion=v1.7.1-4-g9008111-dirty -X sigs.k8s.io/release-utils/version.gitCommit=9008111af46dda51d5336b1570d8bf5fe896a524 -X sigs.k8s.io/release-utils/version.gitTreeState="dirty" -X sigs.k8s.io/release-utils/version.buildDate=2022-04-05T18:38:00Z" -o policy-webhook ./cmd/cosign/policy-webhook
stat /Users/hectorj2f/sigstore/cosign/cmd/cosign/policy-webhook: directory not found

Ticket Link

Fixes

Release Note


@hectorj2f hectorj2f added the bug Something isn't working label Apr 7, 2022
@hectorj2f hectorj2f requested a review from cpanato April 7, 2022 13:18
@hectorj2f hectorj2f self-assigned this Apr 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #1718 (fbc56bc) into main (9008111) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   29.26%   29.26%           
=======================================
  Files         141      141           
  Lines        8503     8503           
=======================================
  Hits         2488     2488           
  Misses       5742     5742           
  Partials      273      273           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9008111...fbc56bc. Read the comment docs.

Makefile Outdated Show resolved Hide resolved
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hectorj2f hectorj2f merged commit 92c0322 into sigstore:main Apr 7, 2022
@hectorj2f hectorj2f deleted the fix_chores_Makefile branch April 7, 2022 14:54
@github-actions github-actions bot added this to the v1.8.0 milestone Apr 7, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants