fix build date format for version command #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cpanato <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1644 +/- ##
==========================================
- Coverage 28.28% 27.89% -0.39%
==========================================
Files 137 139 +2
Lines 7864 7972 +108
==========================================
Hits 2224 2224
- Misses 5404 5512 +108
Partials 236 236
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Mar 22, 2022
hectorj2f
approved these changes
Mar 22, 2022
hectorj2f
reviewed
Mar 22, 2022
| @@ -28,7 +28,7 @@ RUNTIME_IMAGE ?= gcr.io/distroless/static | |||
| GIT_TAG ?= dirty-tag | |||
| GIT_VERSION ?= $(shell git describe --tags --always --dirty) | |||
| GIT_HASH ?= $(shell git rev-parse HEAD) | |||
| DATE_FMT = +'%Y-%m-%dT%H:%M:%SZ' | |||
| DATE_FMT = +%Y-%m-%dT%H:%M:%SZ | |||
There was a problem hiding this comment.
I believe we have that format on rekor too https://github.com/sigstore/rekor/blob/main/Makefile#L33
There was a problem hiding this comment.
it sounds like it needs to be changed there too
This was referenced Mar 22, 2022
dlorenc
approved these changes
Mar 22, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Signed-off-by: cpanato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
n/a
Release Note