Add suffix with digest to signature file output for recursive signing #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Block <[email protected]>
dlorenc
approved these changes
Jan 15, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…sigstore#1267) Signed-off-by: Andrew Block <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when specifying an output signature file name during signing, the signature file is overridden when attempting to sign recursively. This feature enables appending a suffix of the image digest to the name of the output file provided. The
@in the digest string is replaced by a-in a similar fashion as when tags are applied to signatures and attestationsNon recursive sign:
<signature_output_provided>Recursive sign:
<signature_output_provided>-<modified_digest>Resolves #1257