Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return error when rekor pub cannot be retrieved, fix file path construction #1157

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

dekkagaijin
Copy link
Member

This (probably) doesn't fix the error being seen by @cpanato during verification on windows, but it does surface the error and take care of some potential root causes

NONE

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can get Windows testing with actions?

if err := tuf.GetTarget(ctx, rekorTargetStr, &buf); err != nil {
panic("error retrieving rekor public key")
return nil, err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be a local cache being old/invalid -- maybe we can say "please remove local cache" (this should be a const str in the tuf code DefaultCache or something)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs welcome :D

If there's a place where we can definitively say "this local cache is old/invalid and we can't fix it," lets do it

@dekkagaijin dekkagaijin merged commit dd53292 into sigstore:main Dec 7, 2021
@dekkagaijin dekkagaijin deleted the fix-windows branch December 7, 2021 19:29
@github-actions github-actions bot added this to the v1.4.1 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants