Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenTelemetry Dependencies to latest #4656

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Update OpenTelemetry Dependencies to latest #4656

merged 6 commits into from
Apr 16, 2024

Conversation

srv-gh-o11y-gdi
Copy link
Collaborator

Update OpenTelemetry Dependencies to latest

@pjanotti pjanotti marked this pull request as ready for review April 16, 2024 00:19
@pjanotti pjanotti requested review from a team as code owners April 16, 2024 00:19
@pjanotti pjanotti marked this pull request as draft April 16, 2024 00:20
@crobert-1
Copy link
Contributor

Oracle DB integration test is failing:

. Missing Metrics: [name: oracledb.tablespace_size.limit
type: IntGauge
 name: oracledb.tablespace_size.usage
type: IntGauge
]

I believe this is a result of open-telemetry/opentelemetry-collector-contrib#32028, as documented in open-telemetry/opentelemetry-collector-contrib#32389. I believe the solution here would be to add the following line to the init docker script:

GRANT SELECT ON DBA_TABLESPACE_USAGE_METRICS TO OTEL;

@crobert-1 crobert-1 mentioned this pull request Apr 16, 2024
Closed
@crobert-1 crobert-1 mentioned this pull request Apr 16, 2024
Merged
@pjanotti pjanotti marked this pull request as ready for review April 16, 2024 16:43
crobert-1
crobert-1 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming CI/CD all passes 👍

@pjanotti pjanotti merged commit 191ad3b into main Apr 16, 2024
27 checks passed
@pjanotti pjanotti deleted the create-pull-request/update-deps branch April 16, 2024 17:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samiura samiura samiura approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srv-gh-o11y-gdi @crobert-1 @samiura @pjanotti