Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separating the python module from the spec #269

Merged
merged 1 commit into from
Jan 25, 2023
Merged

separating the python module from the spec #269

merged 1 commit into from
Jan 25, 2023

Conversation

jacobagilbert
Copy link
Member

@jacobagilbert jacobagilbert commented Jan 17, 2023 •
edited
Loading

The Python module has been broken out here https://github.com/gnuradio/sigmf-python

I think we are ready to do this.

@jacobagilbert jacobagilbert self-assigned this Jan 17, 2023
@jacobagilbert jacobagilbert added meta Not spec or code development, but about the project itself code labels Jan 17, 2023
Teque5
Teque5 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@Teque5 Teque5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the extensions going to live here too?

@jacobagilbert
Copy link
Member Author

Yep, that's the intention.

@jacobagilbert
Copy link
Member Author

Two approvals, full speed ahead.

@jacobagilbert jacobagilbert merged commit 7f05cc9 into sigmf-v1.x Jan 25, 2023
@jacobagilbert jacobagilbert deleted the remove_python_module branch January 27, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teque5 Teque5 Teque5 approved these changes

@777arc 777arc 777arc approved these changes

Assignees

@jacobagilbert jacobagilbert

Labels
meta Not spec or code development, but about the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobagilbert @Teque5 @777arc