Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating license for python module to LGPLv3 #262

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

jacobagilbert
Copy link
Member

@jacobagilbert jacobagilbert commented Dec 23, 2022

This specifies the LGPLv3 License for the python module instead of the unsuitable CC license the spec uses. It is not ideal to have the spec and python code in the same repository under different licenses, but that will be addressed post v1.1.0 release when they are split into their own repos.

Closes #254

DONT MERGE for now.

@bhilburn
Copy link
Contributor

bhilburn commented Jan 3, 2023

I'm good with the LGPL license, but the header swapped in to the code files in this PR is actually the GPLv3 header, not the LGPL header?

@jacobagilbert
Copy link
Member Author

jacobagilbert commented Jan 3, 2023

Thanks @bhilburn you are correct - I got this notice from here but failed to read the entire section 🤦.

I switched to the SPDX License Identifier for simplicity which should resolve this annoyance (and less text)

@jacobagilbert
Copy link
Member Author

I think this is mergable, but no real rush. Removing the DONT MERGE label.

Copy link
Contributor

@bhilburn bhilburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobagilbert - I see that you changed it to an SPDX identifier, but it looks like you used the GPL string instead of the LGPL string?

SPDX-License-Identifier: GPL-3.0-or-later

@jacobagilbert
Copy link
Member Author

Good grief. Sorry, thanks Ben - FIXED!

Copy link

@dkozel dkozel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with LGPL being a reasonable license for a reference implementation of our open spec. The compelling immediate desire is to increase the usage of the open SigMF file format over proprietary or less useful formats, not to compel users of the SigMF file format to release their higher level applications.

Just a note, there is no GNU Radio Foundation to hold the copyright. Nor was their in 2021... "GNU Radio project" could be used (though technically I don't think the project can hold copyright since it isn't a formal legal entity). But as intent is a big part of court interpretations of copyright cases I'd still go with "GNU Radio project". @bhilburn?

@jacobagilbert
Copy link
Member Author

jacobagilbert commented Jan 4, 2023

Yeah, I assume that is just boilerplate that got copied as the module expanded...this is probably a good time to get that correct as well. This project has never required copyright assignment either, so its not clear what we can/should do regarding that notice.

@bhilburn i think you are the expert opinion here :)

@bhilburn
Copy link
Contributor

bhilburn commented Jan 4, 2023

Great catch, @dkozel.

Making it "GNU Radio Project" communicates intent, but also indicates assignment, which as @jacobagilbert notes, we have never / will never do.

Just make it "Copyright Multiple Authors", which is fine

@jacobagilbert
Copy link
Member Author

OK, thats better. Thanks!

sigmf/archive.py Outdated Show resolved Hide resolved
@jacobagilbert
Copy link
Member Author

I think this is ready. If I can get a few final reviews ill merge ahead of a release.

@gmabey
Copy link
Contributor

gmabey commented Jan 5, 2023

Looks good to me,

sigmf/__init__.py Outdated Show resolved Hide resolved
@jacobagilbert jacobagilbert merged commit cb1421f into sigmf-v1.x Jan 6, 2023
@jacobagilbert jacobagilbert deleted the update_python_to_lgplv3 branch January 17, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License Considerations for Python Module
6 participants