-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating license for python module to LGPLv3 #262
Conversation
7a55ea3
to
254d957
Compare
I'm good with the LGPL license, but the header swapped in to the code files in this PR is actually the GPLv3 header, not the LGPL header? |
Thanks @bhilburn you are correct - I got this notice from here but failed to read the entire section 🤦. I switched to the SPDX License Identifier for simplicity which should resolve this annoyance (and less text) |
254d957
to
f7b7d46
Compare
I think this is mergable, but no real rush. Removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacobagilbert - I see that you changed it to an SPDX identifier, but it looks like you used the GPL string instead of the LGPL string?
SPDX-License-Identifier: GPL-3.0-or-later
f7b7d46
to
7adab0c
Compare
Good grief. Sorry, thanks Ben - FIXED! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with LGPL being a reasonable license for a reference implementation of our open spec. The compelling immediate desire is to increase the usage of the open SigMF file format over proprietary or less useful formats, not to compel users of the SigMF file format to release their higher level applications.
Just a note, there is no GNU Radio Foundation to hold the copyright. Nor was their in 2021... "GNU Radio project" could be used (though technically I don't think the project can hold copyright since it isn't a formal legal entity). But as intent is a big part of court interpretations of copyright cases I'd still go with "GNU Radio project". @bhilburn?
Yeah, I assume that is just boilerplate that got copied as the module expanded...this is probably a good time to get that correct as well. This project has never required copyright assignment either, so its not clear what we can/should do regarding that notice. @bhilburn i think you are the expert opinion here :) |
Great catch, @dkozel. Making it "GNU Radio Project" communicates intent, but also indicates assignment, which as @jacobagilbert notes, we have never / will never do. Just make it "Copyright Multiple Authors", which is fine |
7adab0c
to
69845ef
Compare
OK, thats better. Thanks! |
69845ef
to
ebc29e1
Compare
I think this is ready. If I can get a few final reviews ill merge ahead of a release. |
Looks good to me, |
ebc29e1
to
8e6065b
Compare
This specifies the LGPLv3 License for the python module instead of the unsuitable CC license the spec uses. It is not ideal to have the spec and python code in the same repository under different licenses, but that will be addressed post v1.1.0 release when they are split into their own repos.
Closes #254
DONT MERGE
for now.