Add formal SigMF Collection support #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobagilbert
force-pushed
the
add_collection_handling
branch
from
65f9fb5
to
b702e80
Compare
jacobagilbert
force-pushed
the
add_collection_handling
branch
4 times, most recently
from
9eef0c8
to
97bf734
Compare
jacobagilbert
force-pushed
the
add_collection_handling
branch
from
97bf734
to
54f0cd4
Compare
777arc
reviewed
Jan 6, 2023
777arc
reviewed
Jan 6, 2023
777arc
reviewed
Jan 6, 2023
this creates a base SigMFMetafile class that Recording and Collection objects inherit from for common functions, also updates README to provide an example of this.
jacobagilbert
force-pushed
the
add_collection_handling
branch
from
54f0cd4
to
52f618f
Compare
777arc
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a base SigMFMetafile class that Recording and Collection objects inherit from for common functions. This also separates some of the Collection object keys that were somewhat haphazardly thrown into the SigMFFile class despite having no real use there yet.
It does not handle archiving or schema based validation of collections yet, those common functions should probably be added to the base class. Example code to test these new features are in the README on this branch
Also updates README to provide an example of collections - Closes #252