CI Pipeline for Python Package #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
777arc
changed the title
jacobagilbert
approved these changes
Nov 24, 2022
|
I thought we said the python package was supposed to work under python 3.6, which would catch #253 assuming there's a unit test that covers that part. Python is pretty good about backwards compatibility across major releases so 3.6 should be the only thing we need to test under. |
|
Ah yeah you are correct, sorry. For some reason I thought i tested that in 3.6 and it changed in 3.8... Disregard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs unit tests on each push, and will email you if there's an error. Not sure if it blocks a merge, that might be in repo settings.