deprecate tuples as collection Recording pointers #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhilburn collections support is ready for libsigmf, but it needs this specification change - can you take a look and provide thoughts? |
bhilburn
requested changes
Jul 14, 2022
There was a problem hiding this comment.
@jacobagilbert - I like this proposed solution. Good idea / design. My comments are all copy related, not design related.
|
Bumping, looks like no changes since last review |
jacobagilbert
force-pushed
the
deprecate_tuples_as_collection_pointers
branch
from
567d03d
to
d95db9c
Compare
|
@bhilburn thanks for the ping. I think I have addressed most of the feedback. I also did a quick scan through this for |
jacobagilbert
force-pushed
the
deprecate_tuples_as_collection_pointers
branch
2 times, most recently
from
45c86e8
to
89fb246
Compare
jacobagilbert
force-pushed
the
deprecate_tuples_as_collection_pointers
branch
from
89fb246
to
4a99554
Compare
jacobagilbert
commented
Dec 13, 2022
| ], | ||
| "antenna:hagl": { | ||
| "name": "hagl-basename", | ||
| "hash": "9c1ab7285c13644cef5d910dc774ca63d1921f91318417cfadc71c4d7f3acf85ec3c5b05e9335e9cc310b1557de517519c76da540b08886a0e440d71e1271fd0" |
There was a problem hiding this comment.
All these example hashes were previously sha256 but the spec calls out sha512, fixed.
jacobagilbert
force-pushed
the
deprecate_tuples_as_collection_pointers
branch
from
4a99554
to
8ddda7d
Compare
777arc
approved these changes
Dec 14, 2022
bhilburn
approved these changes
Jan 3, 2023
jacobagilbert
force-pushed
the
deprecate_tuples_as_collection_pointers
branch
from
8ddda7d
to
fcde174
Compare
in favor of JSON objects, avoiding nested vectors (flatbuffers limitation) and also permitting expansion within this object.
jacobagilbert
force-pushed
the
deprecate_tuples_as_collection_pointers
branch
from
5efad4c
to
5621307
Compare
|
Issues addressed, multiple approvals. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done in favor of JSON objects, avoiding nested vectors (prohibited by flatbuffers) and also permitting expansion within this object.