remove rfml.sigmf-ext.md from canonical extensions #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This extension was designed and used by NSWC Crane to create the datasets for DARPA's RFMLS program. Unfortunately, the government's lawyers determined those datasets could never be released, and no publicly releasable datasets were made. I'm not aware of anyone else using this particular extension as a result. I am also in favor of removal, and if it needs to come back, more details and examples would make it more broadly useful. |
|
Ok, thanks for the context. I'll talk w/ Crane and see if I can get some info. If a good faith effort here fails I'll press along with deprecation on the grounds of this being proprietary. |
|
I think this PR is ready. |
072e00a
to
4a8ef4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension has no examples and it is not clear how to use it. Removal would NOT affect the validity of any SigMF using it, but I have been asked about what SigMF using this should look like several times over the past 6 months, and I have no useful answer.
Happy to change this PR to "include examples and documentation for rfml.sigmf-ext.md if that is possible! The 'label heirarchy' seems to be the unique feature this extension offers over what is already in the core spec.