Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to pip in README #227

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Conversation

tammojan
Copy link
Contributor

I think the installation instructions should not advise everyone to build the package from source. Using pip is common practice for any python package. Of course the build from source should be in the readme, but as option b.

I think the installation instructions should not advise everyone to build the package from source. Using pip is common practice for any python package. Of course the build from source should be in the readme, but as option b.
Copy link
Member

@jacobagilbert jacobagilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, thanks @tammojan

Copy link
Collaborator

@Teque5 Teque5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Teque5 Teque5 merged commit 8293fa8 into sigmf:sigmf-v1.x Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants