Support metadata only distributions, complete nonstandard dataset support (v2) #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobagilbert
force-pushed
the
alt_metadata_only
branch
from
f4e1185
to
7c41642
Compare
bhilburn
reviewed
Dec 4, 2021
bhilburn
reviewed
Dec 4, 2021
jacobagilbert
force-pushed
the
alt_metadata_only
branch
2 times, most recently
from
be7a3d1
to
2c72f03
Compare
|
Before this is merged, i need to go through and run the code changes; this was done open loop and while vscode is happy this needs to be tested. |
jacobagilbert
force-pushed
the
alt_metadata_only
branch
2 times, most recently
from
aaf9333
to
5a5abc5
Compare
|
@bhilburn comments addressed; i had to make a few changes to the code but it is behaving well with everything i can throw at it. |
|
@Teque5 if you have a few minutes to review the code here that would be appreciated |
also adds code support for NCDs and metadata only distributions
jacobagilbert
force-pushed
the
alt_metadata_only
branch
from
5a5abc5
to
2968706
Compare
|
LGTM 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines a new field
core:metadata_onlywhich allows a metadata file to be distributed by its self.This also improves tooling and schema for non-standard recordings. There are some edge cases here that are resolved by an explicit dataset hierarchy in the case of conflicts:
core:datasetfield (Non-Compliant Dataset) if it existsAlternate to #198
Closes #183