SigMF Collections #157
Merged
SigMF Collections #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I also think we should add the following to the global core namespace:
|`collection`|false|string|The name of the `collection` this file is part of (if applicable).|This will allow unambiguous traversal from an arbitrary file to all other files in the same collection...though it does limit a file to be in a single collection (which I think is also a good idea). Possibly should even make this value mandatory for all streams?
|
@jacobagilbert - Updated the PR with your feedback. Regarding restricting recordings to only being part of one collection, I think we get that for "free", here, by the global |
|
Are there currently plans to add support for SigMF Collections to the SigMF Python package? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #151 and implements the design discussed in that PR's thread.
Draft implementation of SigMF Collections, creating a new top-level object in a new file. This PR updates the SigMF spec with this feature, and also updates the canonical Antenna extension to use it.