Move settings to db #2581
Open
Move settings to db #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eberonsh
force-pushed
the
moveSettingsToDB
branch
2 times, most recently
from
fe14830
to
91965ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #2581 +/- ##
==========================================
- Coverage 87.77% 87.65% -0.13%
==========================================
Files 894 903 +9
Lines 40414 40720 +306
Branches 5274 5304 +30
==========================================
+ Hits 35474 35693 +219
- Misses 3721 3805 +84
- Partials 1219 1222 +3
Continue to review full report at Codecov.
|
eberonsh
force-pushed
the
moveSettingsToDB
branch
4 times, most recently
from
8106350
to
5ec1e6f
Compare
chessbr
suggested changes
Aug 9, 2021
eberonsh
force-pushed
the
moveSettingsToDB
branch
22 times, most recently
from
05c3243
to
e7c2069
Compare
eberonsh
force-pushed
the
moveSettingsToDB
branch
7 times, most recently
from
f50ba79
to
65edb08
Compare
… SHUUP_REFERENCE_NUMBER_PREFIX to DB.
…_ENABLE_MULTIPLE_SHOPS, SHUUP_ENABLE_MULTIPLE_SUPPLIERS, SHUUP_MANAGE_CONTACTS_PER_SHOP, SHUUP_ALLOW_EDITING_ORDER.
…HUUP_ADMIN_ALLOW_HTML_IN_VENDOR_DESCRIPTION.
eberonsh
force-pushed
the
moveSettingsToDB
branch
3 times, most recently
from
1ce96b0
to
a6dbdea
Compare
eberonsh
force-pushed
the
moveSettingsToDB
branch
from
a6dbdea
to
baaa064
Compare
eberonsh
commented
Aug 19, 2021
| return True | ||
|
|
||
|
|
||
| class BaseSettingsForm(forms.Form): | ||
| title = None | ||
| encrypted_fields = [] |
There was a problem hiding this comment.
We need to specify in each form which fields are encrypted.
eberonsh
commented
Aug 20, 2021
|
|
||
|
|
||
| def move_settings_to_db(apps, schema_editor): | ||
| configuration.set(None, SHUUP_HOME_CURRENCY, getattr(settings, "SHUUP_HOME_CURRENCY", "EUR")) |
There was a problem hiding this comment.
I took the setting values from shuup.core.settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.