Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ› unexpected result when attrs are not separated by space #879

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

shufo
Copy link
Owner

@shufo shufo commented Oct 16, 2023

Description

When html tag attributes are not separated by space like class=""foo="",
formatter will output unexpected result

βœ… Closes: #878

Related Issue

How Has This Been Tested?

see tests

When html tag attributes are not separated by space like class=""foo="",
formatter will output unexpected result

βœ… Closes: #878
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests βœ…

Comparison is base (8b19654) 78.97% compared to head (8be1957) 81.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
+ Coverage   78.97%   81.34%   +2.36%     
==========================================
  Files          16       16              
  Lines        1731     1731              
  Branches      411      411              
==========================================
+ Hits         1367     1408      +41     
+ Misses        349      309      -40     
+ Partials       15       14       -1     
Files Coverage Ξ”
src/formatter.ts 94.01% <ΓΈ> (+3.55%) ⬆️

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@shufo shufo merged commit 847a0d1 into main Oct 16, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Formatting Bug]: 1.38.4 seems to breaks when attributes are not separated by whitespace
1 participant