Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward options when calling #promote_cached to promote_block #689

Conversation

4ndypanda
Copy link
Contributor

If Shrine::Attacher.promote_block { |**options| ... } is declared with backgrounding plugin and we call attacher.promote_cached(**options), the options were not being forwarded to the .promote_block.

If `Shrine::Attacher.promote_block { |**options| ... }` is declared with
backgrounding plugin and we call `attacher.promote_cached(**options)`,
the options were not being forwarded to the `.promote_block`.
Copy link
Member

@janko janko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@janko janko merged commit c5c0546 into shrinerb:master Jun 14, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants