Cairo 2.1.1 #138
Merged
Cairo 2.1.1 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ft: update contract to new_syntax * chore: format starknet exercise and update readme * Update README.md * fix: correct starknet-exercise-one
|
Continued from #137 |
enitrat
reviewed
Aug 20, 2023
src/starklings_runner.rs
Outdated
| runner.find_function("::main")?, | ||
| &[], | ||
| args.available_gas, | ||
| StarknetState::default(), | ||
| ) | ||
| .with_context(|| "Failed to run the function.")?; | ||
| match result.value { | ||
| cairo_lang_runner::RunResultValue::Success(values) => ret_string | ||
| .push_str(format!("Run completed successfully, returning {values:?}").as_str()), | ||
| cairo_lang_runner::RunResultValue::Success(values) => { |
There was a problem hiding this comment.
Have you verified that this works correctly? I think using the ret_string variable was required here to get the output of the run
I tried an my previous solution for enum2.cairo is not compiling anymore - but the error message doesn't appear
There was a problem hiding this comment.
Ohh, I tested with some arbitrary cairo and it seemed to compile/show error. Lemme check enum example.
There was a problem hiding this comment.
I reverted to old signatures but it was still happening,
This seemed to fix the issue.
|
@codeWhizperer few fixes on exercises,
@enitrat Lemme know if things looks good. |
|
I'm planning to use Starklings for Basecamp tomorrow. Any chance we can get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #136
Thanks @codeWhizperer for updating the contract exercises!